Zope Subversion Repository

Zope: zope.security/trunk/src/zope/security/checker.py

Drop support for Python 2.4 and 2.5.

Replace deprecated 'zope.component.adapts' usage with equivalent
'zope.component.adapter' decorator.

Replace deprecated 'zope.interface.classProvides' usage with equivalent
'zope.interface.provider' decorator.

Replace deprecated 'zope.interface.implements' usage with equivalent
'zope.interface.implementer' decorator.

Remove CVS-era Id fossils.

Conform to repository policy.

Removed the dependency on the zope.exceptions package: zope.security.checker
now imports ``DuplicationError`` from zope.exceptions if available, otherwise
it defines a package-specific ``DuplicationError`` class which inherits from
Exception.

- Added compatibility with Python 2.6 abstract base classes.

Made ``pytz`` a soft dependency.

The checker for ``pytz.UTC`` is created / tested only if the package
is already present.

Run ``bin/test_pytz`` to run the tests with ``pytz`` on the path.

revert 99070

Make UUIDs rocks, as (not) discussed on zope-dev http://mail.zope.org/pipermail/zope-dev/2009-April/035724.html

Add zope.i18nmessage.Message to non-proxied basic types, as it's immutable and it was done by zope.app.security.

Add __name__ and __parent__ to list of available by default attributes. It was also done by zope.app.security before.

Don't define checker for deprecated sets on Python 2.6.
Fix package's mailing list address and homepage.
Remove zpkg stuff.

Fixed bug:
The special system_user object wasn't actually a user (principal).

Also cleaned up some circular import issues.

merge form the branch nikhil_n-py25: made zope.security work with python2.5

Moving code to satellite.

conditional imports, specific deps

removed whitespace

Remove some deprecated aliases.
Remove some deprecated methods.

Add a Decimal field and widget to Zope 3.  The field and widget almost exactly
mirror the existing ones for float.

Also adds security declarations for Decimal.  The reason why I didn't just
declare Decimal objects to be rocks is that they're not really immutable:

  >>> from decimal import Decimal
  >>> d = Decimal("1.24")
  >>> d._exp = -1
  >>> d
  Decimal("12.4")

Minor documentation fixes.

Fixed issue 564, http://www.zope.org/Collectors/Zope3-dev/564

Binary set operations (&, |, ^, -) weren't avaliable for proxied sets.

Also added tests for set checkers.

Added C implementations of interface __call__ and __adapt__.  Also
Added __call__ for declarations as an alternatite to isOrExtends.
This allows invocation through a slot, which is slightly faster.

These changes won back most of the losses in request time I have up
when I fixed an adapter-cache bug yesterday. :)

This will also improve debugging a little bit, since it will no longer
be necessary to step through the rather uninteresting __call__ and
__adapt__ methods.

Merge of jim-adapter branch:

This branch has three major refactorings on it:

- A redesign of the adapter registration machinery

- A major simplification of local component management

  See zope.component.interfaces.IComponentRegistry.

- A flexible system for combining component registries.

- A beginning of the migration of packages out of zope.app.

- A new package for doing deferred imports.  This allows you
  to make names available at the package level without creating
  circular imports.  See zope.deferredimport and see
  zope.component.__init__ for examples of it's use.  This package
  also provides a way to deprecate names in a module.

- Deprecation of zope. i18nmessageid.MessageID

I should have created checkin messages for individual sets of related
changes, but there were just too many for the time allowed.

Fixing double definition of defineChecker() in zope.security.checker.

Make changes as discussed in http://www.zope.org/Collectors/Zope3-dev/506: canWrite now does not raise Forbidden if canAccess does not, effectively.

Integrated newer version of zdaemon that has more robust tests.

I think this fixes our security proxy issues. Gary, that's cool with you?

Reverting checkin just made, because a test failed. The test explained why 
it wants this behavior. While I disagree with the reasoning, I am too 
tired right now to pick the fight and risk a lot of breakage.

The check method can emit two types of exceptions and both should be 
caught.

Massive style cleanup: Move to new raise exception style; for motivation, see:

  http://permalink.gmane.org/gmane.comp.web.zope.zope3/13884

Set security on set and frozenset if running with Python 2.4

Added tzinfo and UTC (a commonly used instance of tzinfo) to the BasicTypes mapping, which used by checkers. tzinfo info objects now act like other date components (datetime, time, etc.) in that they're not security proxied (see tests for examples).

No longer re-proxying objects that provide an explicit __Security_checker__.

When you get an Unauthorized error, now you can see the object in addition to
the attribute and permission names in the traceback.

Should a minor change like this be mentioned in doc/CHANGES.txt?

Cosmetic fixes.

Add two convenience functions: canWrite and canAccess.  While the tests for this package are not doc tests, I included doctest-like comments in the tests.  Since these functions are primarily conveniences for app code, I imported them in the package __init__.

Merged from ZopeX3-3.0 branch:

  r27201 | jim | 2004-08-20 18:14:11 -0400 (Fri, 20 Aug 2004) | 2 lines

  Removed unneeded removeAllProxies calls.

  ------------------------------------------------------------------------
  r27200 | jim | 2004-08-20 17:47:26 -0400 (Fri, 20 Aug 2004) | 2 lines

  Removed unneeded removeAllProxies calls.

  ------------------------------------------------------------------------
  r27199 | jim | 2004-08-20 17:42:45 -0400 (Fri, 20 Aug 2004) | 2 lines

  Converted removeAllProxies calls to the prefered removeSecurityProxy.

  ------------------------------------------------------------------------
  r27198 | jim | 2004-08-20 17:07:23 -0400 (Fri, 20 Aug 2004) | 2 lines

  Converted a package with one module to a regulat module.

  ------------------------------------------------------------------------
  r27197 | jim | 2004-08-20 17:05:39 -0400 (Fri, 20 Aug 2004) | 2 lines

  Made the dependency subscriber trusted

  ------------------------------------------------------------------------
  r27196 | jim | 2004-08-20 17:05:37 -0400 (Fri, 20 Aug 2004) | 8 lines

  Converted removeAllProxies calls to the prefered removeSecurityProxy.

  D      src/zope/app/security/interfaces
  D      src/zope/app/security/interfaces/__init__.py
  A  +   src/zope/app/security/interfaces.py

  Converted a package with one module to a regulat module.

  ------------------------------------------------------------------------
  r27195 | jim | 2004-08-20 16:29:43 -0400 (Fri, 20 Aug 2004) | 4 lines


  Added a zapi.isinstance method that works with security proxies.


  ------------------------------------------------------------------------
  r27194 | jim | 2004-08-20 15:26:59 -0400 (Fri, 20 Aug 2004) | 3 lines

  Added some defensive programming to work around a lame implicit Python
  string-formatting behavior.

  ------------------------------------------------------------------------
  r27193 | jim | 2004-08-20 15:26:57 -0400 (Fri, 20 Aug 2004) | 2 lines

  Removed unneeded removeAllProxies call

  ------------------------------------------------------------------------
  r27192 | jim | 2004-08-20 15:26:55 -0400 (Fri, 20 Aug 2004) | 3 lines

  Fixed a problem with the security dclarations to make calling
  removeAllProxies unnecessary.

  ------------------------------------------------------------------------
  r27191 | jim | 2004-08-20 14:20:12 -0400 (Fri, 20 Aug 2004) | 2 lines

  Removed unneeded removeAllProxies calls.

  ------------------------------------------------------------------------
  r27190 | jim | 2004-08-20 14:20:07 -0400 (Fri, 20 Aug 2004) | 2 lines

  Converted removeAllProxies calls to the prefered removeSecurityProxy.

  ------------------------------------------------------------------------
  r27189 | jim | 2004-08-20 13:02:06 -0400 (Fri, 20 Aug 2004) | 6 lines

  Added "trusted" option for defining trusted subscribers.

  Deprecated zope.security.trustedRemoveSecurityProxy and
  zope.security.getProxiedObject. Use zope.security.removeSecurityProxy
  instead.  (This should also be used rather than removeAllProxies.)

  ------------------------------------------------------------------------
  r27188 | jim | 2004-08-20 13:02:03 -0400 (Fri, 20 Aug 2004) | 4 lines

  Deprecated zope.security.trustedRemoveSecurityProxy and
  zope.security.getProxiedObject. Use zope.security.removeSecurityProxy
  instead.  (This should also be used rather than removeAllProxies.)


Also converted additional removeAllProxies calls to the prefered
removeSecurityProxy. (These were on the trunk, but not the branch.)

Moved forbidden and unauthorized exception definitions to
zope.security.interfaces.

Removed the special treatment of exception classes.  Previously, we
  treated excptions and xception clases as basic objects that were not
  proxied. This strategy seems overly lax. The problem is that we
  don't really kow how to raise or catch exceptions if exceptions and
  exception classes are proxied. The answer is not to be lax with
  exceptions. Rather, we'll need to change the way exceptions are
  handled in untrusted python code. This will require code
  manipulation, which we've avoided until recently.

Rearranged the security apis, largely combining security policies and
interactions. Now security policies are just interaction factories --
usually just the interaction class.  

See:

  http://mail.zope.org/pipermail/zope3-dev/2004-July/011656.html

Unauthorized no-longer takes keyword arguments.

Removed __metaclass__ and made classes inherit 'object'.

Also made most classic classes new-style classes.

Updated module doc strings where appropriate.

Converted XXX and TODO comments about deprecated interface methods
to BBB comments.

Jim, I put today's date in, but the backward compat actually goes
back a few months. Maybe you want to change the dates.

Renamed _always_available to _available_by_default as hinted by a XXX. 
You need to recompile Zope.

Fix a typo. Make Unauthorized exception take a name and permission arguments on constructor, and fix two places where a message was being passed instead of a name

Got rid of weird branch to check for __Security_checker__ when a
checker was passed to ProxyFactory. The check never did anything and
had no point. The method is advertized to use the passed checker to
override the normal checker.  This is used to override the normal
checker when needed.

Merged from jim-work branch r26112

Added missing security declarations to make interface declaration
introspection work on proxied classes.

fix typos

Added security declarations for Set and ImmutableSet.

Fix Python 2.4 compatibility.
Merged from revision 25958 on the ZopeX3-3.0 branch.

While Python 2.3 used a single iterator type to support iteration over
dictionaries, Python 2.4 uses different types to support items, keys,
and values iterations.  We need to make sure declarations are made for
all of these types.

Shameless hack to increase security checking performance

It is much faster to call operators, especially from C, than it is to
call methods.  Now if a checker implements __setitem__, it will be
called rather than check or check_getattr.  Similarly, if a checker 
implements __getitem__, it will be called rather than proxy. Yes, this
is an egregious hack, but it does yield a significant speedup and is
thus worth it. Hopefully, it is well marked.

This change reduces the time required to display a sample contents
page by about 5%.  This percentage will increase as other
optimizations are made and things get faster.

Implemented Checker in C for performance

Changed the implementation of CombinedChecker to suclass Checker

Changed basic checkers to use dictionaries.

Now when you create checkers, you must pass one or 
two dictionary objects. We used to allow functions 
to be passed that would be called to get the permission
needed to access a name.  It turns out that this generality
wasn't needed or used.  If we need this in the furture, we
can add custom checkers.  For now, we only allow
dictionaries, as that will enable more efficient checker
implementation. 

Removed unused NonPrivateChecker

Added a warning that tracing security will be done differently in the
future.

Removed the unused DecoratedChecker class.

Began implementing more security checking in C

Implemented zop.security.checker.selectChecker in C.

Updated to use ZPL 2.1.

Tell subversion to expand the Id keyword:
  - replaced old CVS expansion with a clean $Id$
  - set the svn:keywords property to "Id"

When you check-in files in the future and want $Id$ to be expanded,
make sure it reads "$Id$" in that file; then set svn:keywords to "Id".

Renamed getInteraction to queryInteraction.

Merged Zope3/branches/mgedmin-security 24595:24640

This is UnificationOfRequestsAndSecurityContextsThroughUse:
  - Security managers and security contexts are gone.
  - Interactions and participations replace them.
  - BaseRequest is now IParticipation.
  - request.user was renamed to request.principal because of the above.

Set mime-type or svn-eol property from cvs expansion data

Renamed interface methods:

isImplementedByInstancesOf to implementedBy
  isImplementedBy            to providedBy

Addded header to C code and improved doc strings

Added security declarations for zope.interface.interface.Method. This
is necessary to get preconditions from security-proxied interfaces.

Updated the interface-related checkers.

Added a weakref.ref checker.

Remove code that isn't needed now that we require Python 2.3.

Cases include future statements for generators, special case
definitions of builtins like basestring and enumerate, a few uses of
types that are unnecessary.

Typo: persmission -> permission. Add __conform__ to the list of always available attributes

Added a repr to Global objects.

Added a function for getting module checkers.

Changed the default security declaration for modules to expose only
__name__. It's unclear why __name__ is needed, but there's a test that
depends on it.

Modified the arguments for ForbiddenAttribute to include the object whose attribute is forbidden.

Made the introspector work for interfaces again, plus some whitespace cleanup here and there.

When iterating over security-proxied sequences, Python failed to
recognize a ForbiddenAttributeError as an AttributeError. To work
around this, we now don't raise a ForbiddenAttribute for __iter__ if
the object doesn't have an __iter__ attribute.

Add security declarations for generators.

Added an XXX comment inside a conditional to express surprise at
one possible branch of the code. I'll need to revisit this later.

Tidied up long lines.

Security checker debugging output now has verbosity levels.

Documented the behavior of CombinedChecker explicitly.  Fixed a bug where
CombinedChecker could raise a ForbiddenAttribute instead of Unauthorized.

Documented Checker.permission_id and setattr_permission_id in an interface
(INameBasedChecker).

Remove the dependency on permission_id/setattr_permission_id from
CheckerLoggingMixin.  I do not think anyone cares about the distinction of
'Public' and 'Granted' when debugging checkers.

Make CombinedChecker log things when ZOPE_WATCH_CHECKERS is set.

Make checker debugging messages more readable and more grep friendly
(Vika & Marius)

Made interface specifications picklable.  This is necessary to deal
with interface assertions on instances and will be needed for
interface assertions on persistent classes.

Implemented descriptor for __Security_checker__ of context wrappers.
This descriptor gets a checker for the wrapper and for the proxied object,
and returns a checker combined from both of those.
If either the wrapper or the proxied object has no checker defined, then
the checker for the proxied object or the wrapper is returned,
respectively.
If no checkers are defined, None is returned.

Added a CombinedChecker that provides a proxy to two checkers.

Converted raise statements to the lazy-instantiation form.

Added a DecoratedChecker.

Merged some of the work done by SteveA and MariusG on the
stevea-decorators-branch.

* Refactored acting on WATCH_CHECKERS into a reusable and unobtrusive
  mixin class. Execution speed will be faster when WATCH_CHECKERS is false.

* Improved and clearer implementation of ProxyFactory.

* Added comprehensive test of ProxyFactory.

* Made an explicit TrustedCheckerBase marker type to show the connection
  between the checker module and the proxy module.

* Added a note about the poor naming of _always_available. The name
  _available_by_default would better reflect actual use. That is, it is
  possible to make an _always_available name unavailable.

* Added a BasicTypes_examples dict that can be imported into unit tests
  that want to check whether basic types are handled properly.

* Added comprehensive test of ProxyFactory.

Fixed several bugs in security assertions for builtin types (and their
methods).

Added security assertions for interface specifications.

Importgeddon part the second. Removed unused imports throughout the
source tree. This should have taken care of most unused imports
in Zope 3. :)

Fixed http://collector.zope.org/Zope3-dev/143

All classic classes other than Exceptions now use _typeChecker.

Reverted my change as Guido pointed out why exception classes need to
be unwrapped as well as instances. This needs more thinking about
though, as no tests failed...

If all extension instances are unwrapped, and extension classes are
included inline in the code, then there is no problem with comparison.

I'll talk to people and experiment tomorrow, and perhaps re-check this in.

Made the checker for ClassType objects more sensible.

Report obj.__class__ as well as type(obj) in the TracebackSupplement.

Add a __traceback_supplement__ when a permission check fails with the
class module+name, to help tracking down permission errors.

BasicTypes: MessageID is no longer a rock.

BasicTypes: Do not proxy zope.i18n.messageid.MessageID objects.

I'm not sure this is the 100% right thing to do, but it makes
TAL/PageTemplates work.  Otherwise we'd have to unwrap them to do
isinstance tests in zope/tales/tales.py, Context.evaluateText() and
that didn't seem like the right thing either.

Also, add ZPL header and re-organize imports.

Changed a 0 and 1 to a False and True

Added __mro__ to the attributes you can get from a type.

timedelta, date, time, datetime objects made rocks after verifying with Tim that they are immutable.

__repr__ is now always allowed by security checkers.
This is important because you can always get around a restriction
on __repr__ by putting the object inside a tuple, dict or list, and
calling __repr__ on the tuple, dict, or list.

We discovered at Rotterdam that it is painful and non-intuitive to
protect __repr__ on tuples, dicts and lists.

So, it is better to make __repr__ publicly and obviously available.

Modified CheckerPublic so that it can be pickled and unpickled without
loss of identity. This is necessary so that it can be stored and used
in persistent objects.

Changed the marker object, CheckerPublic to be picklable (as a global
object). This will allow the value to be safely stored in persistent
objects.

More obvious way to get a bool in python 2.3.
Improved comment.

Updated the datetime checker to relect the addition of some new
methods.

Use keyword instead of positional arg (and Boolean instead of 1)
to make it more obvious to someone browsing the code what is going
on when the interface 'names' method is called.

Collapsing datetime and datetimetz into datetime, and time and timetz
into time, as discussed on Zope3-Dev.

More renaming.

Grand renaming:

- Renamed most files (especially python modules) to lower case.

- Moved views and interfaces into separate hierarchies within each
  project, where each top-level directory under the zope package
  is a separate project.

- Moved everything to src from lib/python.

  lib/python will eventually go away. I need access to the cvs
  repository to make this happen, however.

There are probably some bits that are broken. All tests pass
and zope runs, but I haven't tried everything. There are a number
of cleanups I'll work on tomorrow.

	Diffs between and
	Generate output suitable for use with a patch program
	Type of Diff should be a Colored Diff Long Colored Diff Unidiff Context Diff Side by Side

---

Sort log by: Not sorted Commit date Revision

---

webmaster@zope.org Powered by ViewCVS 1.0-dev

ViewCVS and CVS Help